[libcxx-commits] [PATCH] D81824: [LIBCXX] add possibility to load an additional test configuration to CMake

Dominik Montada via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 16 00:31:01 PDT 2020

gargaroff added a comment.

Oh, I just noticed that I forgot to put the link to this Diff in the email earlier. Sorry about that!

In D81824#2092984 <https://reviews.llvm.org/D81824#2092984>, @ldionne wrote:

> I've posted it at https://reviews.llvm.org/D81846, please let me know what you think.
> The one downside I see with this approach here is that it's still always using the default (old) config all the time, whereas D81846 <https://reviews.llvm.org/D81846> allows bypassing it completely.

Might it make sense to combine both of our patches? I certainly like your patch as it gets right of the old config and the need to use lit directly if a custom config should be used. However I also like the ability of not having to copy-paste all of the boilerplate from the default config just to set up some additional parameters that I care about. Therefore I would love to see both approaches combined.

By the way, if you know some additional reviewers which would be interested in this, feel free to add them to the discussion!

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list