[libcxx-commits] [PATCH] D81823: adds equality for spaceship types for themselves

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked an inline comment as done.
cjdb added a subscriber: CaseyCarter.
cjdb added a comment.

Thanks @miscco! Hoping this lands very soon.

> NOTE: I am not a maintainer so you should hold on merging this until a maintainer greenlights it. That said this seem close to the trivially correct clause

That won't be a problem, as I don't have write access. I'll need someone to merge it on my behalf please.



================
Comment at: libcxx/test/std/language.support/cmp/cmp.weakord/weakord.pass.cpp:164
+
+    static_assert(std::weak_ordering::equivalent != std::weak_ordering::less);
+    static_assert(std::weak_ordering::equivalent ==
----------------
miscco wrote:
> I am wondering if we really need `B != A` if we already checked `A != B` on the library side.
> 
> Can we trust the compiler to have its own valid tests?
@CaseyCarter mentioned in my `same_as` patch that a lot of the MSVC STL type-traits tests tend to do the testing for the compiler, which is my motivation here. Also, since I expect these names to be ultimately user-defined, I wanted to be 100% sure that they're distinct.

I have no issues deleting them if you've got strong feelings :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81823/new/

https://reviews.llvm.org/D81823