[libcxx-commits] [PATCH] D81477: [libc++] Avoid UB in year_month_day_last::day() for incorrect months

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 9 09:52:28 PDT 2020


ldionne added a comment.

Note that a test was added in cb347a1106a76e248a6c0d78451a018b20662c03 <https://reviews.llvm.org/rGcb347a1106a76e248a6c0d78451a018b20662c03>, and in fact this UB did trigger a failure in the ASAN bot due to the added test.

So basically this commit fixes the LWG issue, and the tests for it have been added in cb347a1106a76e248a6c0d78451a018b20662c03 <https://reviews.llvm.org/rGcb347a1106a76e248a6c0d78451a018b20662c03>. Sorry if that's confusing, everything should have been added in this commit, but I didn't fully understand the issue yet and I didn't know this commit was going to be necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81477/new/

https://reviews.llvm.org/D81477





More information about the libcxx-commits mailing list