[libcxx-commits] [PATCH] D81414: [libcxx] Fix LWG 2875: shared_ptr::shared_ptr(Y*, D, […]) constructors should be constrained.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Do we have tests that `shared_ptr` isn't constructible from incompatible array types? If not, could we add some?

Otherwise, mostly LGTM.



================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp:71
+        static_assert(!std::is_constructible<std::shared_ptr<int>, int*, no_move_deleter>::value,
+                      "");
+    }
----------------
Nit: Please don't wrap here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81414/new/

https://reviews.llvm.org/D81414