[libcxx-commits] [PATCH] D77505: [libc++] Implement <numbers>

[Raul Tambre via Phabricator via libcxx-commits]

tambre added a comment.

I've addressed the comments.



================
Comment at: libcxx/include/numbers:103
+template <class T>
+concept floating_point = std::is_floating_point_v<T>;
+
----------------
ldionne wrote:
> I don't see that concept defined inside `<numbers>` in http://wg21.link/p0631 -- should this be kept as an implementation detail instead?
> 
> Or was it moved there by another paper? In all cases, if that is public according to the Standard, please add tests for it.
Yes, this is an implementation detail. I've prefixed it with two underscores now.

Technically this should be `std::floating_point` from the concepts library, but libc++ doesn't have a full implementation of that yet. Besides, it seems a bit heavy to pull in `<concepts>` just for one thing, when it's simple enough to define here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77505/new/

https://reviews.llvm.org/D77505