[libcxx-commits] [PATCH] D81190: [libc++] Link against libatomic when it is found

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:71
+      "mkdir -p %T",
+      "%{cxx} -xc++ %s %{flags} %{compile_flags} %{link_flags} -o %t.exe"
+    ]
----------------
jfb wrote:
> I think your filenames need to be quoted properly otherwise spaces in filenames will bork stuff (above and below).
Lit will expand filenames like `%t` and directories like `%T`, the assumption is that it will quote it properly for shell evaluation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81190/new/

https://reviews.llvm.org/D81190