[libcxx-commits] [PATCH] D81190: [libc++] Link against libatomic when it is found

[JF Bastien via Phabricator via libcxx-commits]

jfb added inline comments.


================
Comment at: libcxx/test/libcxx/selftest/dsl/dsl.sh.py:105
+    def test_valid_program_builds(self):
+        source = """int main() { }"""
+        self.assertTrue(dsl.sourceBuilds(self.config, source))
----------------
Here and for the others, `int main(int, char**)` :smile:


================
Comment at: libcxx/utils/libcxx/test/dsl.py:71
+      "mkdir -p %T",
+      "%{cxx} -xc++ %s %{flags} %{compile_flags} %{link_flags} -o %t.exe"
+    ]
----------------
I think your filenames need to be quoted properly otherwise spaces in filenames will bork stuff (above and below).


================
Comment at: libcxx/utils/libcxx/test/features.py:39
+                                                                  std::atomic<Large> x;
+                                                                  int main() { return x.load(), x.is_lock_free(); }
+                                                                """)),
----------------
`int main(int, char**)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81190/new/

https://reviews.llvm.org/D81190