[libcxx-commits] [PATCH] D81174: [libcxx] Return "real" pointer from array<T, 0>::data.

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 4 11:00:25 PDT 2020


zoecarver added a comment.

> I am still having trouble to unterstand what benefit this has.

The benefit is two-fold. First, it fixes the ABI break. Second, this seems like the preferred behavior, if possible. IMO it's the most intuitive implementation. After the LWG issue around `array<T, 0>` goes through, I suspect the wording will be clarified to make the result of `data() != nullptr`. And, for people who use `array<T, 0>` (if there are any) it will be nice not to have to update their code to expect `data()` to return `nullptr` and then again to expect `data()` not to return nullptr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81174/new/

https://reviews.llvm.org/D81174





More information about the libcxx-commits mailing list