[libcxx-commits] [PATCH] D80895: [libcxx] adds operator<=> for basic_string

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.nonmembers/string_opcmp/pointer_string.pass.cpp:35
+    typedef std::string S;
+    test("", S(""), std::strong_ordering::equal);
+    test("", S("abcde"), std::strong_ordering::less);
----------------
curdeius wrote:
> I may be missing something, but it seems that there are no tests for the basic cases like:
> "abc" < "acb"
> "cba" > "aaa"
> All (non-equal) tests fall into the shorter/longer check.
Done. I also added these tests to the inequality tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80895/new/

https://reviews.llvm.org/D80895