[libcxx-commits] [libcxxabi] bf61891 - [libc++abi] Fix incorrect XFAILs for mis-aligned _Unwind_Exception on Apple

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 3 07:08:33 PDT 2020


Author: Louis Dionne
Date: 2020-06-03T10:08:15-04:00
New Revision: bf61891146be78a693ff6a52f05e1a7c8147ba4d

URL: https://github.com/llvm/llvm-project/commit/bf61891146be78a693ff6a52f05e1a7c8147ba4d
DIFF: https://github.com/llvm/llvm-project/commit/bf61891146be78a693ff6a52f05e1a7c8147ba4d.diff

LOG: [libc++abi] Fix incorrect XFAILs for mis-aligned _Unwind_Exception on Apple

The problem mentioned in the XFAILs has been resolved in macosx10.15, so
the test is now XPASSing on that platform.

rdar://63640184

Added: 
    

Modified: 
    libcxxabi/test/test_exception_address_alignment.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/test_exception_address_alignment.pass.cpp b/libcxxabi/test/test_exception_address_alignment.pass.cpp
index b462659fc888..b870290a2b10 100644
--- a/libcxxabi/test/test_exception_address_alignment.pass.cpp
+++ b/libcxxabi/test/test_exception_address_alignment.pass.cpp
@@ -9,10 +9,14 @@
 // UNSUPPORTED: no-exceptions
 // UNSUPPORTED: c++03
 
-// The system unwind.h on OS X provides an incorrectly aligned _Unwind_Exception
-// type. That causes these tests to fail. This XFAIL is my best attempt at
-// working around this failure.
-// XFAIL: darwin && libcxxabi-has-system-unwinder
+// The system unwind.h on older OSX versions provided an incorrectly aligned
+// _Unwind_Exception type. That causes these tests to fail on those platforms.
+// XFAIL: macosx10.14 && libcxxabi-has-system-unwinder
+// XFAIL: macosx10.13 && libcxxabi-has-system-unwinder
+// XFAIL: macosx10.12 && libcxxabi-has-system-unwinder
+// XFAIL: macosx10.11 && libcxxabi-has-system-unwinder
+// XFAIL: macosx10.10 && libcxxabi-has-system-unwinder
+// XFAIL: macosx10.9 && libcxxabi-has-system-unwinder
 
 // Test that the address of the exception object is properly aligned as required
 // by the relevant ABI


        


More information about the libcxx-commits mailing list