[libcxx-commits] [PATCH] D80904: [libcxx] adds spaceship for vector

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/compare:686
+    } else {
+        if (t < u) return weak_ordering::less;
+        if (u < t) return weak_ordering::greater;
----------------
miscco wrote:
> I have to look it up but what about string orderings here?
See http://eel.is/c++draft/expos.only.func#2.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80904/new/

https://reviews.llvm.org/D80904