[libcxx-commits] [PATCH] D84943: [libc++] Remove workarounds for missing rvalue references

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__hash_table:2565
     __h->__next_ = nullptr;
-    return _LIBCPP_EXPLICIT_MOVE(__h);  // explicitly moved for C++03
+    return (__h);  // explicitly moved for C++03
 }
----------------
mclow.lists wrote:
> The comment here (and in other places) is now incorrect.
Indeed, good catch. Do you agree we could just `return __h;` and let the compiler RVO? I think that would be correct for all places where this comment appears.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84943/new/

https://reviews.llvm.org/D84943