[libcxx-commits] [PATCH] D84801: [libcxx] [test] XFAIL midpoint.float.pass on AArch64 with compiler-rt

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/libcxx/test/config.py:280
+        
+        if self.config.target_triple:
+            self.config.available_features.add(self.config.target_triple)
----------------
This is already added by Lit IIUC.


================
Comment at: libcxx/utils/libcxx/test/config.py:283
+
+        if self.get_lit_conf('use_compiler_rt'):
+            self.config.available_features.add('use_compiler_rt')
----------------
Not super happy about this for a couple of reasons:

1. It adds more to `config.py`, which I'm trying to get rid of.
2. There's nothing associated to the `use_compiler_rt` feature except the Lit feature itself. It's kind of like adding a new feature whose sole purpose is to `XFAIL` this specific test. Instead, it might make more sense to detect whether subnormal floats are supported?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84801/new/

https://reviews.llvm.org/D84801