[libcxx-commits] [PATCH] D84759: [libunwind] Provide a way to set '_LIBUNWIND_IS_BAREMETAL' through cmake.

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Minor nits, but this seems like a reasonable control to give to the user.



================
Comment at: libunwind/CMakeLists.txt:365
 
+if (LIBUNWIND_IS_BAREMETAL)
+  add_compile_flags(-D_LIBUNWIND_IS_BAREMETAL)
----------------
LLVM style is to not have the space after the `if`.


================
Comment at: libunwind/CMakeLists.txt:366
+if (LIBUNWIND_IS_BAREMETAL)
+  add_compile_flags(-D_LIBUNWIND_IS_BAREMETAL)
+endif()
----------------
Could you use `add_compile_definitions` instead please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84759/new/

https://reviews.llvm.org/D84759