[libcxx-commits] [PATCH] D84275: [Libcxx] Finish implementing Paper 0202R3

[Nicholas Baron via Phabricator via libcxx-commits]

Nicholas-Baron added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/rotate_copy.pass.cpp:40
 template <class InIter, class OutIter>
 void
 test()
----------------
zoecarver wrote:
> Do you think you could make this test a constexpr and return `true` at the end? That way we test the same thing in both constexpr and non-constexpr mode. `TEST_CONSTEXPR` should work in all modes.
Would this mean changing the call site as well to utilize the returned `true` or is ignoring the return value acceptable in this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84275/new/

https://reviews.llvm.org/D84275