[libcxx-commits] [PATCH] D84421: [libcxx][lit] Support shared directories in ssh executor

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jul 23 08:24:02 PDT 2020


arichardson created this revision.
arichardson added reviewers: libc++, ldionne.
Herald added subscribers: libcxx-commits, dexonsmith.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.

If the remote system and the local one share a directory (using e.g. NFS or
SMB), we can use this to avoid two ssh invocations and one scp invocation.
This commit adds new flags --shared-mount-{local,remote}-path to ssh.py
that when passed use the shared directory instead of scp to upload files
to the remote system.

Example usage:
./bin/llvm-lit projects/libcxx/test "-Dexecutor=/path/to/llvm-project/libcxx/utils/ssh.py --shared-mount-local-path=$(pwd)/tmp --shared-mount-remote-path=/mnt/tmp --host testuser at local-qemu"

This can massively speed up running tests:
Running the libcxxabi test suite via ssh.py on localhost on a Linux test
system takes 87 seconds instead of previously 200.
real	4m10.025s  -> 1m46.165s
user	1m3.192s   -> 0m45.396s
sys	0m12.088s  -> 0m9.795s

Depends on D84097 <https://reviews.llvm.org/D84097>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84421

Files:
  libcxx/utils/ssh.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84421.280138.patch
Type: text/x-patch
Size: 6894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200723/b22d7219/attachment-0001.bin>


More information about the libcxx-commits mailing list