[libcxx-commits] [PATCH] D84275: [Libcxx] Finish implementing Paper 0202R3

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

Hopefully, I can land D65721 <https://reviews.llvm.org/D65721> sometime this week, and then you can rebase this patch on master. Otherwise, feel free to take anything you need from that patch.



================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.rotate/rotate_copy.pass.cpp:31
+
+  return std::distance(std::begin(ib), it) == std::size(ia) &&
+         std::equal(std::begin(ia), middle,
----------------
Rather than returning the tested condition, the convention is to simply assert that the result is what you expect and return `true` from the function. If the assertion fires the function will not be able to be evaluated as a constant expression and the test will fail. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84275/new/

https://reviews.llvm.org/D84275