[libcxx-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

[Logan Smith via Phabricator via libcxx-commits]

logan-5 added a comment.

In D84126#2166952 <https://reviews.llvm.org/D84126#2166952>, @erichkeane wrote:

> I'd suggest disabling this unless the GCC version is >9.1.


I've got a patch addressing exactly this issue here, hoping to get it landed soon: https://reviews.llvm.org/D84292

Thanks again everyone for your patience. After this experience, I can promise next time I do anything like this, it'll go much more smoothly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84126/new/

https://reviews.llvm.org/D84126