[libcxx-commits] [PATCH] D84275: [Libcxx] Finish implementing Paper 0202R3

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added subscribers: zoecarver, ldionne.
ldionne added a comment.

In D84275#2165958 <https://reviews.llvm.org/D84275#2165958>, @miscco wrote:

> [...]
>
> Regarding the tests I would like to point you to the `libcxx/test/std/algorithms` subfolder. For example you can find the tests for `move_backward` here: `libcxx/test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pass.cpp`
>
> As you can see there is a convenient `test()` function. What you have to do is add `TEST_CONSTEXPR_CXX20` before it and then in addition to calling it at runtime also call it inside a `constexpr` co


@Nicholas-Baron Indeed, thanks for working on your first contribution! What @miscco said above is great, and I would add that you probably want to go and add the tests first, then run the test suite and notice that the expected tests are failing. Then you can go ahead and add the required annotations to the library. One example of a patch that constexpr-ified a bunch of tests is https://reviews.llvm.org/D80452, you can take a look at that one.

Also, this appears to have some overlap with https://reviews.llvm.org/D65721. Perhaps you can coordinate with @zoecarver and pick up the work in D65721 <https://reviews.llvm.org/D65721>?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84275/new/

https://reviews.llvm.org/D84275