[libcxx-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

[Nemanja Ivanovic via Phabricator via libcxx-commits]

nemanjai added a comment.
Herald added a subscriber: wuzish.

There is a lot of instances where this warning fires in the unit tests since gtest does not appear to use the `override` keyword. This in turn causes failures on bootstrap builds that use `-Werror`.
An example: http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/10717

Can we either get this pulled until the failures in bootstrap are fixed or quickly fix the code that causes the failures?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84126/new/

https://reviews.llvm.org/D84126