[libcxx-commits] [PATCH] D84200: Disable trivial weak_ptr test on ARM because it is not expected to work.

James Y Knight via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 21 15:52:14 PDT 2020


jyknight added a comment.

Right, the trivial_abi attribute doesn't guarantee that you pass an object in registers, it just gives permission for the implementation to treat the struct as-if it was a trivial struct. On ARM32, since the ABI specifies that trivial structs > 4 bytes are returned indirectly by passing a hidden pointer to a pre-allocated return struct, that's what you get.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84200/new/

https://reviews.llvm.org/D84200





More information about the libcxx-commits mailing list