[libcxx-commits] [PATCH] D82627: Fix CFI issues in <future>

Sat Jul 18 06:41:42 PDT 2020

mclow.lists added a comment.

In D82627#2158668 <https://reviews.llvm.org/D82627#2158668>, @eugenis wrote:

> You are right. CFI also checks reinterpret_casts even if they are not UB, because they are just as likely to be a source of type confusion bugs. So, the choice here is between this change, and _LIBCPP_NO_CFI attribute. The attribute change would ideally move the casts into a helper function to avoid suppressing too much checking.

So are you saying that these aren't really errors?
And the entire purpose of this patch is mistaken: "This change fixes errors.." ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82627/new/

https://reviews.llvm.org/D82627