[libcxx-commits] [PATCH] D82627: Fix CFI issues in <future>

Thu Jul 16 10:49:16 PDT 2020

btolsch added a comment.

In D82627#2155962 <https://reviews.llvm.org/D82627#2155962>, @ldionne wrote:

> In D82627#2154623 <https://reviews.llvm.org/D82627#2154623>, @btolsch wrote:
>
> > What are the annotations that could be used instead of this change?
>
>
> I don't know -- I learned about CFI just now. But my point stands that if this is a tool flagging something that we know is safe as unsafe, then it's just noise and modifying the code to workaround that noise is not the right option.
>
> Reading at https://clang.llvm.org/docs/ControlFlowIntegrity.html, it looks like it's possible to have blacklists for CFI: https://clang.llvm.org/docs/ControlFlowIntegrity.html#cfi-blacklist.
>
> Can you pull in someone from the sanitizers in this review so we can talk about the proper way of blacklisting this function for all users (so that users don't have to do it by themselves each time)?

eugenis@: Can you or someone on your team comment on whether this approach is currently viable?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82627/new/

https://reviews.llvm.org/D82627