[libcxx-commits] [PATCH] D82702: [libc++] Use a proper CMake target to represent libc++ headers

Wed Jul 15 11:15:15 PDT 2020

ldionne added a comment.

In D82702#2153620 <https://reviews.llvm.org/D82702#2153620>, @aeubanks wrote:

> Ah, thanks for the explanation.
>  Does it make sense for `LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY` to only be implicitly set to `ON` if either of `LIBCXX_ENABLE_SHARED` or `LIBCXX_ENABLE_STATIC` are on?

Either that, or we could have `cxx_experimental` link against `cxx-headers`, which would make the build work (even thought that's not what you want). Or we could issue an error to make it clearer.

I think the most consistent thing to do is to link `cxx_experimental` against `cxx-headers`, since it does use the libc++ headers after all.

In D82702#2153626 <https://reviews.llvm.org/D82702#2153626>, @thakis wrote:

> See https://bugs.chromium.org/p/chromium/issues/detail?id=1067216#c7 for background :)

Fair enough.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82702/new/

https://reviews.llvm.org/D82702