[libcxx-commits] [PATCH] D82702: [libc++] Use a proper CMake target to represent libc++ headers

Wed Jul 15 09:36:45 PDT 2020

aeubanks added a comment.

In D82702#2153130 <https://reviews.llvm.org/D82702#2153130>, @ldionne wrote:

> In D82702#2151903 <https://reviews.llvm.org/D82702#2151903>, @aeubanks wrote:
>
> > Is it ok to revert this then?
>
>
> No.
>
> The issue is that your builder builds with `-DLIBCXX_ENABLE_SHARED=OFF -DLIBCXX_ENABLE_STATIC=OFF`, but `LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY` is implicitly set to `ON`. In other words, you're trying to build the libc++ experimental library without building the static or the shared library. If you're trying to disable libc++ from the build, why include it in `LLVM_ENABLE_PROJECTS`?

Ah, thanks for the explanation.
Does it make sense for `LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY` to only be implicitly set to `ON` if either of `LIBCXX_ENABLE_SHARED` or `LIBCXX_ENABLE_STATIC` are on?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82702/new/

https://reviews.llvm.org/D82702