[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D82490#2150470 <https://reviews.llvm.org/D82490#2150470>, @oontvoo wrote:

> > We'll need to add // UNSUPPORTED: clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10 on the tests with a short comment explaining there was a segfault.
>
> Do we also need to document more specifically what the breakages might be?


No.

> 
> 
>   Found another crash:

Please fix it and we'll need to wait for it to land in trunk before we check this patch in. Basically, this patch needs to work on at least one compiler in order to be checked in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490