[libcxx-commits] [PATCH] D82702: [libc++] Use a proper CMake target to represent libc++ headers

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:239
+  add_dependencies(${CXX_HEADER_TARGET} generate-cxx-headers ${LIBCXX_CXX_ABI_HEADER_TARGET})
+  target_include_directories(${CXX_HEADER_TARGET} INTERFACE ${output_dir})
+
----------------
When I replace this line with:

```
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
  target_compile_options(${CXX_HEADER_TARGET} INTERFACE /I "${output_dir}")
else()
  target_compile_options(${CXX_HEADER_TARGET} INTERFACE -I "${output_dir}")
endif()
```

everything seems to be working. So whatever is filtering out the include path seems to be only affecting `target_include_directories`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82702/new/

https://reviews.llvm.org/D82702