[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

Tue Jul 7 15:24:34 PDT 2020

oontvoo added a comment.

In D82490#2136229 <https://reviews.llvm.org/D82490#2136229>, @ldionne wrote:

> In D82490#2134450 <https://reviews.llvm.org/D82490#2134450>, @oontvoo wrote:
>
> > Sorry for the sloppy testing. I initially ran these tests with google internal checkout+build systems because it was faster and just patched the tests over here once they passed (hence missing the typo in the code here). The fact that we had previously tested this change with a large set of internal code made me incorrectly assume it was safe. I hadn't realised assertion was turnt off.
> >
> > Anyway, I think the "Fix" here would be in clang. It crashed while trying to determine whether the copy and move ctors were deleted in clang::Sema::checkIllFormedTrivialABIStruct. (Sent D83263 <https://reviews.llvm.org/D83263> )
> >
> > I'll let you know once that is resolved
>
>
> Thanks, I'll be waiting for you to ping this again!

The crash bug patch has been submitted. PTAL. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490