[libcxx-commits] [PATCH] D81954: Remove the try/catch codepath if `swap` is `noexcept`.

[Michael Park via Phabricator via libcxx-commits]

mpark marked 2 inline comments as done.
mpark added inline comments.


================
Comment at: libcxx/include/variant:1070
+          __all<(is_nothrow_move_constructible_v<_Types> &&
+                 is_nothrow_swappable_v<_Types>)...>::value;
+#endif
----------------
lewissbaker wrote:
> Why is the `is_nothrow_swappable_v` requirement checked here?
> The code below is just calling __generic_construct and __move_nothrow, neither of which seem to call swap().
Thanks! I've followed up with https://reviews.llvm.org/D83274


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81954/new/

https://reviews.llvm.org/D81954