[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

Sun Jul 5 19:12:05 PDT 2020

oontvoo added a comment.

Does this only happen on Fuschia? How do I repro it?

(I've run the tests `make check-cxx` and didn't see any issue)

Thanks!

In D82490#2131949 <https://reviews.llvm.org/D82490#2131949>, @phosek wrote:

> In D82490#2131523 <https://reviews.llvm.org/D82490#2131523>, @oontvoo wrote:
>
> > Rolling forward + fix typos and unused variables in tests
>
>
> This is causing an assertion failure with tip-of-tree Clang:
>
>   [485/749] Building CXX object libcxx/src/CMakeFiles/cxx_shared.dir/any.cpp.obj
>   FAILED: libcxx/src/CMakeFiles/cxx_shared.dir/any.cpp.obj 
>   /b/s/w/ir/k/recipe_cleanup/clangew4FcF/llvm_build_dir/./bin/clang++ --target=x86_64-unknown-fuchsia --sysroot=/b/s/w/ir/k/cipd/sdk/arch/x64/sysroot  -DNDEBUG -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilibcxx/include/c++build -I/b/s/w/ir/k/llvm-project/libcxx/include -I/b/s/w/ir/k/cipd/sdk/pkg/fdio/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -ffunction-sections -fdata-sections -ffile-prefix-map=/b/s/w/ir/k/recipe_cleanup/clangew4FcF/llvm_build_dir/runtimes/runtimes-x86_64-unknown-fuchsia-bins=../recipe_cleanup/clangew4FcF/llvm_build_dir/runtimes/runtimes-x86_64-unknown-fuchsia-bins -ffile-prefix-map=/b/s/w/ir/k/llvm-project/= -no-canonical-prefixes -O2 -g  -fPIC   -DLIBCXX_BUILDING_LIBCXXABI -UNDEBUG -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wno-user-defined-literals -Wno-covered-switch-default -Wno-ignored-attributes -Wno-error -include /b/s/w/ir/k/recipe_cleanup/clangew4FcF/llvm_build_dir/runtimes/runtimes-x86_64-unknown-fuchsia-bins/libcxx/__config_site -std=c++14 -MD -MT libcxx/src/CMakeFiles/cxx_shared.dir/any.cpp.obj -MF libcxx/src/CMakeFiles/cxx_shared.dir/any.cpp.obj.d -o libcxx/src/CMakeFiles/cxx_shared.dir/any.cpp.obj -c /b/s/w/ir/k/llvm-project/libcxx/src/any.cpp
>   clang++: clang/include/clang/AST/DeclCXX.h:680: bool clang::CXXRecordDecl::defaultedCopyConstructorIsDeleted() const: Assertion `(!needsOverloadResolutionForCopyConstructor() || (data().DeclaredSpecialMembers & SMF_CopyConstructor)) && "this property has not yet been computed by Sema"' failed.
>   clang++: error: clang frontend command failed due to signal (use -v to see invocation)
>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490