[libcxx-commits] [PATCH] D73525: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/CMakeLists.txt:877
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-      target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
+      target_compile_options(${target} PUBLIC "/FI${site_config_path}")
     else()
----------------
ldionne wrote:
> smeenai wrote:
> > ```
> >       target_compile_options(${target} PUBLIC /FI "${site_config_path}")
> > ```
> > 
> > is more consistent with the below case, if it works.
> Either way works for me. @phosek Please try using this suggestion, otherwise commit as-is.
I tested it locally and it seems to be working so I'll  use the suggested version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73525/new/

https://reviews.llvm.org/D73525