[libcxx-commits] [PATCH] D71214: [libc++] reduce <complex> parsing time

Nikita Kniazev via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 29 17:18:26 PST 2020


nick marked an inline comment as done.
nick added a comment.

No, I do not have commit rights.



================
Comment at: libcxx/include/complex:1444
 {
-    basic_ostringstream<_CharT, _Traits> __s;
-    __s.flags(__os.flags());
----------------
ldionne wrote:
> I'm thinking there must be a reason why it was written that way, but I can't think of any and your version indeed seems more straightforward.
I tried to dig into history and the code is from initial commit, so I hoped I will get insights during the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71214/new/

https://reviews.llvm.org/D71214





More information about the libcxx-commits mailing list