[libcxx-commits] [PATCH] D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present

[Louis Dionne via Phabricator via libcxx-commits]

ldionne reopened this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This commit broke testing when `LIBCXX_ENABLE_STATIC` is `OFF`. This includes the configuration in Apple's CMake cache. It also seems to assume that we want to carry on supporting standalone builds of libc++abi, which isn't our intention (unless something's changed recently).

Also, you didn't wait for one of the usual maintainers to sign off on this.

I'm tempted to revert this but I won't do it immediately.

Can you show me how you're building libc++abi which makes it _not work_ when you set `LIBCXXABI_ENABLE_SHARED` to `OFF`?



================
Comment at: libcxxabi/CMakeLists.txt:101
+       "Whether the libc++abi tests should link with the shared libc++ library"
+       ${LIBCXX_ENABLE_SHARED})
+
----------------
Here, `LIBCXX_ENABLE_SHARED` will be `OFF` by default (even though it's normally `ON` by default in libc++'s CMake), because libc++abi's CMake is loaded before libc++'s CMake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71894/new/

https://reviews.llvm.org/D71894