[libcxx-commits] [PATCH] D73514: [libcxx] Add a std::string_view pretty printer for libcxx.

Wed Jan 29 08:53:37 PST 2020

EricWF accepted this revision.
EricWF added a reviewer: saugustine.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM.  But I would also like the opinion of Sterling, since they work in this code most often.

================
Comment at: libcxx/utils/gdb/libcxx/printers.py:935
             "string": StdStringPrinter,
+            "string_view": StdStringViewPrinter,
             "tuple": StdTuplePrinter,
----------------
Should we have a basic_string_view printer as well?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73514/new/

https://reviews.llvm.org/D73514