[libcxx-commits] [PATCH] D73516: [libcxx] Link against android_support when needed

[Dan Albert via Phabricator via libcxx-commits]

danalbert added inline comments.


================
Comment at: libcxx/CMakeLists.txt:784
+  if (ANDROID AND ANDROID_PLATFORM_LEVEL LESS 21)
+    target_link_libraries(${target} PUBLIC android_support)
+  endif()
----------------
This should probably be `PRIVATE` rather than `PUBLIC`. The consumer doesn't need it if their `minSdkVersion` is 21+. The real constraint might be describable with a generator expression, but I'm not sure. (if we don't generate config files for this it doesn't matter anyway)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73516/new/

https://reviews.llvm.org/D73516