[libcxx-commits] [PATCH] D73436: [libunwind] Treat assembly files as C on mingw
Shoaib Meenai via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Jan 26 16:06:27 PST 2020
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: mclow.lists.
LGTM
================
Comment at: libunwind/src/CMakeLists.txt:28
+if (MINGW)
+ # Current CMake (3.16) doesn't build assembly sources for windows/gnu
+ # targets properly, so treat them as C files.
----------------
Maybe you could clarify that it's all CMake versions as of 3.16 that have this issue, not just 3.16 specifically.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73436/new/
https://reviews.llvm.org/D73436
More information about the libcxx-commits
mailing list