[libcxx-commits] [PATCH] D72501: [libcxx] Support Python 3.8 in the test suite

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.


================
Comment at: libcxx/utils/libcxx/test/target_info.py:216
+            # Python 3.8.
+            return platform.linux_distribution()
+        except AttributeError:
----------------
jroelofs wrote:
> Did you consider using this instead? One downside is that it brings in one more dependency.
> 
> 
> ```
> import distro
> return distro.linux_distribution(full_distribution_name=False)
> ```
I did, but as far as I understand, the community doesn't really want any dependencies.

I've also been answered on the mailing lists that bringing it it [wouldn't really worth it](http://lists.llvm.org/pipermail/llvm-dev/2019-December/137457.html).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72501/new/

https://reviews.llvm.org/D72501