[libcxx-commits] [PATCH] D72160: Optimize / partially inline basic_string copy constructor

[Eric Fiselier via libcxx-commits]

I don't see why you think the given error maps to this change.

This change isn't in the set of changes in the build you point to:
http://lab.llvm.org:8014/builders/netbsd-amd64/builds/834/

And the build before it doesn't fail.
http://lab.llvm.org:8014/builders/netbsd-amd64/builds/833/

Can you elucidate why this change is responsible?

On Mon, Jan 20, 2020 at 3:53 AM Michał Górny via Phabricator <
reviews at reviews.llvm.org> wrote:

> mgorny added a comment.
>
> I'm afraid this breaks stuff. TableGen built against libc++ after this
> change misbehaves:
>
>   [18/31] Building ARMGenSystemRegister.inc...
>   FAILED: lib/Target/ARM/ARMGenSystemRegister.inc
>   cd /home/motus/netbsd8/netbsd8/build-stage2 &&
> /home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen
> -gen-searchable-tables -I
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM -I
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/include -I
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM/ARM.td
> --write-if-changed -o lib/Target/ARM/ARMGenSystemRegister.inc -d
> lib/Target/ARM/ARMGenSystemRegister.inc.d
>
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM/ARM.td:1269:1:
> error: Reached EOF without matching #endif
>
>   ^
>   #0 0x000000000049b032 llvm::sys::PrintStackTrace(llvm::raw_ostream&)
> (/home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen+0x49b032)
>   #1 0x000000000049905c llvm::sys::RunSignalHandlers()
> (/home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen+0x49905c)
>   #2 0x000000000049b5e0 SignalHandler(int)
> (/home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen+0x49b5e0)
>   Stack dump:
>   0.      Program arguments:
> /home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen
> -gen-searchable-tables -I
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM -I
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/include -I
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target
> /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM/ARM.td
> --write-if-changed -o lib/Target/ARM/ARMGenSystemRegister.inc -d
> lib/Target/ARM/ARMGenSystemRegister.inc.d
>   ninja: build stopped: subcommand failed.
>
>
> http://lab.llvm.org:8014/builders/netbsd-amd64/builds/834/steps/ninja%20build%20local/logs/stdio
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D72160/new/
>
> https://reviews.llvm.org/D72160
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200120/e734ab0e/attachment.html>