[libcxx-commits] [PATCH] D72980: Add test for spaceship operator to __config

[David Zarzycki via Phabricator via libcxx-commits]

davezarzycki created this revision.
davezarzycki added a reviewer: chandlerc.
davezarzycki added a project: libc++.
Herald added a reviewer: mclow.lists.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The libcxx test suite auto-detects spaceship operator, but __config does not. This has been broken for over a month when using top-of-tree clang. This also really ought to be fixed before 10.0.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72980

Files:
  include/__config


Index: include/__config
===================================================================
--- include/__config
+++ include/__config
@@ -1355,10 +1355,9 @@
 #define _LIBCPP_HAS_NO_COROUTINES
 #endif
 
-// FIXME: Correct this macro when either (A) a feature test macro for the
-// spaceship operator is provided, or (B) a compiler provides a complete
-// implementation.
+#if !defined(__cpp_impl_three_way_comparison) || __cpp_impl_three_way_comparison < 201907L
 #define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR
+#endif
 
 // Decide whether to use availability macros.
 #if !defined(_LIBCPP_BUILDING_LIBRARY) &&                                      \


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72980.238957.patch
Type: text/x-patch
Size: 645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200118/0d1c3e41/attachment-0001.bin>