[libcxx-commits] [PATCH] D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D72952#1827678 <https://reviews.llvm.org/D72952#1827678>, @JamesNagurne wrote:

> In D72952#1827668 <https://reviews.llvm.org/D72952#1827668>, @smeenai wrote:
>
> > The diff here looks weird ... it looks like a diff against your previous diff instead of a diff against master? (Phabricator says the line you're deleting has `LANGUAGE ASM` instead of `LANGUAGE C`, as it does on master.)
>
>
> Eek, sorry. We use CodeCollaborator internally, which would have effectively shown the diff from the original commit to the final (after 2 change sets), which would have shown the C in the before and nothing after. I mistakenly treated Phabricator the same way erroneously.
>
> I'll re-upload this so it looks right. My apologies!


No worries! LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72952/new/

https://reviews.llvm.org/D72952