[libcxx-commits] [PATCH] D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C

James Nagurne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 17 14:05:41 PST 2020


JamesNagurne added a reviewer: phosek.
JamesNagurne added inline comments.


================
Comment at: libunwind/src/CMakeLists.txt:27-29
 set_source_files_properties(${LIBUNWIND_ASM_SOURCES}
                             PROPERTIES
+                            LANGUAGE ASM)
----------------
smeenai wrote:
> Do you need this at all, or will CMake just do the right thing by default?
I thought about that. I think it will do the right thing, but I was paranoid :)

I'll get rid of it, run it with a dummy CMAKE, and update


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72952/new/

https://reviews.llvm.org/D72952





More information about the libcxx-commits mailing list