[libcxx-commits] [libcxx] 59919c4 - [libc++] Fix Windows DLL build for string.

Eric Fiselier via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 16 12:01:32 PST 2020


Author: Eric Fiselier
Date: 2020-01-16T15:01:12-05:00
New Revision: 59919c4d6b6370da7133bbca0d31844e21646bb1

URL: https://github.com/llvm/llvm-project/commit/59919c4d6b6370da7133bbca0d31844e21646bb1
DIFF: https://github.com/llvm/llvm-project/commit/59919c4d6b6370da7133bbca0d31844e21646bb1.diff

LOG: [libc++] Fix Windows DLL build for string.

We need to mark string::npos with _LIBCPP_FUNC_VIS on the first
in-class declaration, otherwise it might get ignored

Added: 
    

Modified: 
    libcxx/include/string

Removed: 
    


################################################################################
diff  --git a/libcxx/include/string b/libcxx/include/string
index 255630126816..313ef9f67900 100644
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -785,6 +785,7 @@ private:
     __compressed_pair<__rep, allocator_type> __r_;
 
 public:
+    _LIBCPP_FUNC_VIS
     static const size_type npos = -1;
 
     _LIBCPP_INLINE_VISIBILITY basic_string()


        


More information about the libcxx-commits mailing list