[libcxx-commits] [PATCH] D72720: [libcxx] Allow manually specifying locales for use in tests via CMake

Thu Jan 16 07:40:28 PST 2020

broadwaylamb added a comment.

In D72720#1823146 <https://reviews.llvm.org/D72720#1823146>, @jroelofs wrote:

> My long term plan for this was to have a set of "remote" TargetInfo objects that mirror/wrap these "local" ones, and have the SSHExecutor sub them in as appropriate, but this seems like a pragmatic compromise.

I went ahead and added `LinuxRemoteTI` in D72847 <https://reviews.llvm.org/D72847>. Can I ask you to take a look? If there's anything there that needs more work, or even if I got you completely wrong, please let me know.

If D72847 <https://reviews.llvm.org/D72847> is approved, I'll close this review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72720/new/

https://reviews.llvm.org/D72720