[libcxx-commits] [PATCH] D72687: [libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/CMakeLists.txt:80
+
+option(LIBCXX_LINK_TESTS_WITH_SHARED_LIBCXX
+       "Whether the libc++ tests should link with the shared libc++ library"
----------------
Have you considered using `cmake_dependent_option`? That way you don't need to do the validation below yourself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72687/new/

https://reviews.llvm.org/D72687