[libcxx-commits] [PATCH] D72640: [libcxx] Qualify make_pair in searcher implementations to prevent ADL

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

> there seems to be an issue with a `vector<value_type> __scratch` in a helper function that I don't understand

My relatively uneducated guess is that it should have been a `vector<size_t> __scratch` all along. If you make that change, then your test case compiles. Also, if you're searching in a string of `char`, then `char` is smaller than `size_t` and bad stuff happens:
https://godbolt.org/z/i52zkN triggers an assertion failure `corrupted size vs. prev_size` and I can't even figure out where that message is coming from!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72640/new/

https://reviews.llvm.org/D72640