[libcxx-commits] [PATCH] D69554: [libcxx] [Windows] Make a more proper implementation of strftime_l for mingw with msvcrt.dll

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D69554#1731282 <https://reviews.llvm.org/D69554#1731282>, @mclow.lists wrote:

> Shouldn't there be a test for this new behavior?


I looked into the tests, and I think this codepath should be hit by existing tests in e.g. std/input.output/iostream.format/ext.manip/put_time.pass.cpp. (The test in itself doesn't work exactly as is though as msvcrt.dll, which this patch affects, provides a very limited set of locales, not including the one used by that test.)

@mclow.lists - ok to commit this one?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69554/new/

https://reviews.llvm.org/D69554