[libcxx-commits] [PATCH] D72343: Add additional benchmark functions to libcxx/benchmarks/string.bench

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 7 09:37:06 PST 2020


EricWF added inline comments.


================
Comment at: libcxx/benchmarks/string.bench.cpp:238
+template <class Length, class Opaque>
+struct StringResizeDefaultInit {
+  static void run(benchmark::State& state) {
----------------
Have you looked at the dissasembly for these benchmarks? They scare me a little bit. I think the compiler may be able to optimize large chunks of them away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72343/new/

https://reviews.llvm.org/D72343





More information about the libcxx-commits mailing list