[libcxx-commits] [PATCH] D71994: SFINAE span default constructor on Extent == 0

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco marked 2 inline comments as done.
miscco added inline comments.


================
Comment at: libcxx/test/std/containers/views/span.cons/default.pass.cpp:17
+
+#ifdef __cpp_lib_concepts
+#include <concepts>
----------------
CaseyCarter wrote:
> Late comment: `<span>` isn't guaranteed to export `__cpp_lib_concepts`; this should include `<version>` before checking `__cpp_lib_concepts`.
I added it one tooth-brushing with my kids ago. That feels like an eternity but if it qualifies as late...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71994/new/

https://reviews.llvm.org/D71994