[libcxx-commits] [PATCH] D72036: [libcxx] span: Cleanup includes

Michael Schellenberger Costa via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 3 01:34:48 PST 2020


miscco updated this revision to Diff 236002.
miscco added a comment.

Do not forward declare array


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72036/new/

https://reviews.llvm.org/D72036

Files:
  libcxx/include/span
  libcxx/test/std/containers/views/span.cons/stdarray.pass.cpp


Index: libcxx/test/std/containers/views/span.cons/stdarray.pass.cpp
===================================================================
--- libcxx/test/std/containers/views/span.cons/stdarray.pass.cpp
+++ libcxx/test/std/containers/views/span.cons/stdarray.pass.cpp
@@ -22,6 +22,7 @@
 
 
 #include <span>
+#include <array>
 #include <cassert>
 #include <string>
 
Index: libcxx/include/span
===================================================================
--- libcxx/include/span
+++ libcxx/include/span
@@ -129,11 +129,10 @@
 */
 
 #include <__config>
-#include <cstddef>      // for ptrdiff_t
-#include <iterator>     // for iterators
 #include <array>        // for array
-#include <type_traits>  // for remove_cv, etc
 #include <cstddef>      // for byte
+#include <iterator>     // for iterators
+#include <type_traits>  // for remove_cv, etc
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #pragma GCC system_header


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72036.236002.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200103/4e012a3c/attachment.bin>


More information about the libcxx-commits mailing list