[libcxx-commits] [PATCH] D72106: Remove unnecessary typenames from std/numerics/c.math/abs.pass.cpp

[Bryce Adelstein Lelbach via Phabricator via libcxx-commits]

wash created this revision.
wash added reviewers: ldionne, EricWF.
wash added a project: libc++.
Herald added subscribers: libcxx-commits, dexonsmith, christof.
Herald added a reviewer: mclow.lists.

There are some unnecessary `typename`s in std/numerics/c.math/abs.pass.cpp; e.g. they're not in dependent code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72106

Files:
  libcxx/test/std/numerics/c.math/abs.pass.cpp


Index: libcxx/test/std/numerics/c.math/abs.pass.cpp
===================================================================
--- libcxx/test/std/numerics/c.math/abs.pass.cpp
+++ libcxx/test/std/numerics/c.math/abs.pass.cpp
@@ -47,7 +47,7 @@
 {
     // On some systems char is unsigned.
     // If that is the case, we should just test signed char twice.
-    typedef typename std::conditional<
+    typedef std::conditional<
         std::is_signed<char>::value, char, signed char
     >::type SignedChar;
 
@@ -63,10 +63,10 @@
 
     // Here there is no guarantee that int is larger than int8_t so we
     // use a helper type trait to conditional test against int.
-    test_abs<std::int8_t, typename correct_size_int<std::int8_t>::type>();
-    test_abs<std::int16_t, typename correct_size_int<std::int16_t>::type>();
-    test_abs<std::int32_t, typename correct_size_int<std::int32_t>::type>();
-    test_abs<std::int64_t, typename correct_size_int<std::int64_t>::type>();
+    test_abs<std::int8_t, correct_size_int<std::int8_t>::type>();
+    test_abs<std::int16_t, correct_size_int<std::int16_t>::type>();
+    test_abs<std::int32_t, correct_size_int<std::int32_t>::type>();
+    test_abs<std::int64_t, correct_size_int<std::int64_t>::type>();
 
     test_abs<long double, long double>();
     test_abs<double, double>();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72106.235941.patch
Type: text/x-patch
Size: 1324 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200102/c057f342/attachment.bin>